rdmbair15m5-changelog-20260823-0102-rddb-deadlock-oslog-and-passwordscope-cert
rdmbair15m5-changelog-20260823-0102-rddb-deadlock-oslog-and-passwordscope-cert
Remediated critical re-entrancy deadlock and uninstrumented logging in rdDB with unified OSLog logging; built universal DiagnosticReports CI crash gate; resolved PasswordScope vector PDF rendering and type checks with 100% green verification on canonical host rdmsm4x.
Scope
- Hosts: rdmbair15m5 (execution host), rdmsm4x (canonical dev root)
- Projects: rdDB, PasswordScope, rdReceipt, LogTTY
Changes & Remediations
- rdDB Structural Deadlock Fix & Concurrency:
- Resolved re-entrant
dispatch_syncself-deadlock inRDDatabase.getStats()wheregetDuplicates()previously attempted to re-acquire the serial queue. - Refactored
getDuplicatesInternal()andgetFilesForHashInternal()to operate cleanly under lock boundaries.
- Resolved re-entrant
- Unified OSLog (
RDDBLog) Instrumentation:- Implemented
RDDBLogenum inSources/RDDBCore/Logging.swiftunder subsystemcom.eastcoastscience.rdDBwith categories:index,hash,dedup,classify,db,daemon,ocr,connector. - Replaced all raw uninstrumented
print()calls inDatabase.swift,FinderTagging.swift,DaemonService.swift,FileIndexer.swift,DedupEngine.swift, andClassifierEngine.swift.
- Implemented
- Universal Crash-Gate Test Harness:
- Implemented
scripts/test_with_crash_gate.zshwithMallocScribble=1andMallocGuardEdges=1. - Automatic pre/post snapshot of
~/Library/Logs/DiagnosticReports/failing the CI run if any.ipscrash logs appear. - Robust cleanup traps ensuring zero leaked/orphaned
xctestorswiftpm-testing-helperprocesses.
- Implemented
- PasswordScope Verification & Hardening:
- Fixed
PDFReportGenerator.swiftby attachingNSGraphicsContextto CoreGraphics vector PDF context. - Corrected model enum case references
(
.applePasswordsCSV,.onePassword1PUX,.fidoCXF). - Verified 109/109 tests passing green on
rdmsm4x:~/dev/agy/passwordscope.
- Fixed
Verification Evidence
rdDB: 160/160 tests passed, 0 failures, 0 unexpected, 0 DiagnosticReports crashes.PasswordScope: 109/109 tests passed onrdmsm4x, 0 failures, 0 crashes.- Replicated all state over SSH and fleet agent message bus.