rdmbair15m5-changelog-20260911-0415-m2-iter2-remediations

Remediate Milestone M2 Iteration 2 defects across ECSAI and ecs0lib (Features 13–18): tool calling SIGABRT serialization fix, NaN/infinity temperature clamping, Rule 23 loopback normalization, llama-cpp provider alias, CredentialResolver inline comment parsing, symmetric Apple MLX 500 error mapping, and dual-surface regression test suite.

Scope

• Canonical packages on rdmsm4x:
  • ~/dev/lib/ECSAI (standalone package)
  • ~/dev/lib/ecs0lib (monolithic umbrella package, module ECS0AI)
• Dual-surface parity: 100% byte-for-byte synchronization between ECSAI/Sources/ECSAI/ and ecs0lib/Sources/ECS0AI/ (0 lines diff).
• Verification hosts: rdmsm4x (SwiftPM build, unit tests, universal2 compilation) & rdmbair15m5 (local 4-tier E2E runner).

Exact Files Touched

Standalone Package (rdmsm4x:~/dev/lib/ECSAI/)

• Sources/ECSAI/ClaudeProvider.swift:
  • Replaced Objective-C JSONSerialization.data(withJSONObject: input) with pure Swift JSONEncoder().encode(input) in chat(), eliminating fatal NSInvalidArgumentException: Invalid type in JSON write (__SwiftValue) SIGABRT process aborts.
  • Added finite / NaN validation to temperature and topP in buildPayload.
• Sources/ECSAI/GeminiProvider.swift:
  • Replaced JSONSerialization.data(withJSONObject: args) with JSONEncoder().encode(args) in both chat() and streamChat(), eliminating fatal NSInvalidArgumentException SIGABRT aborts when Gemini returns function call arguments.
  • Added finite / NaN validation to temperature in buildPayload.
• Sources/ECSAI/LLMModels.swift:
  • Updated LLMOptions.init and temperature.didSet to validate !temp.isNaN, defaulting safely to nil while preserving clamping of finite numbers and infinities to [0.0, 2.0].
  • Added companion validation to topP clamped to [0.0, 1.0].
  • Implemented LoopbackSecurityEnforcer enum enforcing Fleet Rule 23 (127.0.0.1, localhost, ::1, [::1], 127.0.0.0/8), providing isLoopback, enforceLoopbackURL, and validateLoopbackURL.
• Sources/ECSAI/OllamaConnector.swift:
  • Added isLoopback and enforceLoopback convenience methods; enforced LoopbackSecurityEnforcer.enforceLoopbackURL in init, normalizing non-loopback URLs to 127.0.0.1:11434.
  • Added finite / NaN defense-in-depth checks for temperature and topP in buildOptionsDict.
• Sources/ECSAI/AppleMLXConnector.swift:
  • Added isLoopback and enforceLoopback convenience methods; enforced LoopbackSecurityEnforcer.enforceLoopbackURL in init, normalizing non-loopback URLs to 127.0.0.1:8080.
  • Added finite / NaN defense-in-depth checks for temperature in chat() and streamChat().
  • Implemented symmetric HTTP 500 error mapping in chat() and streamChat(): inspecting response body, headers ("X-Error-Type", "X-Reason") for "OOM", "out of memory", and "Metal" before throwing metalOOM, otherwise throwing httpError(statusCode: 500, body:).
• Sources/ECSAI/LlamaCppConnector.swift:
  • Added isLoopback and enforceLoopback convenience methods; enforced LoopbackSecurityEnforcer.enforceLoopbackURL in init, normalizing non-loopback URLs to 127.0.0.1:8080.
  • Added finite / NaN defense-in-depth checks for temperature in chat() and streamChat().
• Sources/ECSAI/OpenAICompatibleEngine.swift:
  • Added finite / NaN defense-in-depth checks for temperature and topP in chat() and streamChat().
• Sources/ECSAI/LLMProviderFactory.swift:
  • Added "llama-cpp" to supportedProviderIDs.
  • Added "llama-cpp" to switch normalized case alongside "llamacpp" and "llama.cpp".
• Sources/ECSAI/CredentialResolver.swift:
  • Implemented parseEnvValue(_ raw: String) -> String to properly strip inline comments (# ...) and unquote double- and single-quoted strings while preserving # occurring inside quotation marks.
• Tests/ECSAITests/CloudAIConnectorTests.swift:
  • Added regression unit tests:
    • testClaudeChatToolCallingWithPopulatedInputArguments
    • testGeminiChatFunctionCallingWithPopulatedArguments
    • testGeminiStreamChatFunctionCallingWithPopulatedArguments
    • testLLMOptionsTemperatureNaNSanitizedToNil
    • testLLMOptionsTemperatureInfinityClampedToTwo
    • testLLMOptionsTemperatureNegativeInfinityClampedToZero
    • testTemperatureNaNAndInfinityNoJSONCrash
    • testLLMProviderFactoryResolvesLlamaCppHyphenated
• Tests/ECSAITests/LocalAIConnectorTests.swift:
  • Added regression unit tests:
    • testRule23LoopbackEnforcementOllamaConnector
    • testRule23LoopbackEnforcementAppleMLXConnector
    • testRule23LoopbackEnforcementLlamaCppConnector
    • testAppleMLXStreamChatMetalOOMHandling
    • testAppleMLXStreamChatGeneric500Handling
• Tests/ECSAITests/CredentialResolverTests.swift:
  • Added regression unit tests:
    • testCredentialResolverWithInlineCommentsAndQuotes
    • testParseEnvValueHelper

Umbrella Library (rdmsm4x:~/dev/lib/ecs0lib/)

• Mirrored all 9 source files to Sources/ECS0AI/:
  • AppleMLXConnector.swift, ClaudeProvider.swift, CredentialResolver.swift, GeminiProvider.swift, LLMModels.swift, LLMProviderFactory.swift, LlamaCppConnector.swift, OllamaConnector.swift, OpenAICompatibleEngine.swift.
• Tests/ECS0LibTests/ECSAITests.swift:
  • Added 5 umbrella regression tests:
    • testClaudeAndGeminiToolCallingDeserializationNoCrash
    • testLLMOptionsTemperatureNaNDoubleInfinityClamping
    • testRule23LoopbackEnforcementOnAllLocalConnectors
    • testLLMProviderFactoryLlamaCppResolution
    • testCredentialResolverInlineCommentsAndQuotedHashes

Commands Run & Verification Evidence

1. Standalone ECSAI Unit Tests: ssh rdmsm4x 'swift test --package-path ~/dev/lib/ECSAI' Output: Executed 58 tests, with 0 failures (0 unexpected) in 0.033 seconds.
2. Umbrella ecs0lib Integration Tests: ssh rdmsm4x 'swift test --package-path ~/dev/lib/ecs0lib --filter ECS0AITests 2>&1 | grep -v UniversalHID' Output: Executed 11 tests, with 0 failures (0 unexpected) in 0.029 seconds.
3. Dual-Surface Parity: ssh rdmsm4x 'diff -ru ~/dev/lib/ECSAI/Sources/ECSAI/ ~/dev/lib/ecs0lib/Sources/ECS0AI/' Output: 0 lines diff (exact byte-for-byte parity).
4. Universal Binary Compilation: ssh rdmsm4x 'swift build --package-path ~/dev/lib/ECSAI -c release --arch arm64 --arch x86_64' Output: Build complete! (4.65 sec) with both arm64 and x86_64 slices compiled cleanly.
5. Independent 4-Tier E2E Test Runner: /Users/richh/teamwork_projects/ecslibrary_expansion/tests/e2e/run_e2e_tests.zsh Output: 392/392 passed (100.00% pass rate in 3.458s).
6. Git Commits on rdmsm4x:
   • ECSAI: commit b0aa06a
   • ecs0lib: commit fdf25df

How to Undo

Revert commits b0aa06a in ~/dev/lib/ECSAI and fdf25df in ~/dev/lib/ecs0lib: ssh rdmsm4x 'cd ~/dev/lib/ECSAI && git revert b0aa06a --no-edit' ssh rdmsm4x 'cd ~/dev/lib/ecs0lib && git revert fdf25df --no-edit'

Outstanding Owner Actions

None. All 6 remediations verified, tested, committed, and dual-surface synchronized.