rdmpw3275m-changelog-20260921-1241-resolve-feat-20260905-12-tyrell-approvals-http

Migrated Tyrell app approvals UI from process-local singleton to localhost daemon HTTP transport (AD-1), eliminating cross-process divergence and resolving FEAT-20260905-12.

Scope

• Hosts affected: Fleet-wide (rdmsm4x, rdmbair15m5, rdmbair13m5, rdmpw3265m, rdmpw3275m, jdmbair13m5) via Tyrell repository.
• Repository: apps/Tyrell (canonical root: rdmsm4x:~/dev/apps/Tyrell).
• Commits: ae18eab (feature implementation), 1eab3ea (session state update).

Exact Files Touched

• Package.swift: Excluded ApprovalClient.swift from TyrellRemoteTransport to satisfy explicit source listing.
• Sources/TyrellCore/Approvals/ApprovalModels.swift: Added shared ApprovalDecisionPayload and ApprovalAPIError models.
• Sources/tyrelld/ApprovalRoutes.swift: Switched token parsing to ServerLogic.extractPresentedToken and filtered approvals using ApprovalRouteLogic.filterApprovals.
• Sources/TyrellAppSupport/ApprovalClient.swift (New): Defined ApprovalTransport protocol, ApprovalTransportError, and TyrellDaemonApprovalClient with loopback resolver and Bearer/X-Tyrell-Token auth.
• Sources/tyrell-app/ApprovalsDestination.swift: Injected client: any ApprovalTransport, removed direct singleton calls to ApprovalQueueActor.shared, and added 3-second ambient polling loop.
• docs/ARCHITECTURE-DECISIONS.md: Amended AD-4 documenting CQRS tables (projection_pending_approvals), REST endpoints (/api/approvals, /api/approvals/{id}/decision), and AD-1 client HTTP boundary.
• Tests/TyrellAppSupportTests/ApprovalClientTests.swift (New): Unit tests covering URL construction, query parameters, headers, and error mapping (4/4 passed).
• Tests/tyrell-appTests/ApprovalsDestinationTests.swift (New): Integration & invariant tests verifying zero ApprovalQueueActor references in tyrell-app/tyrellbar, loopback communication, and mock resolution (5/5 passed).
• SESSION-STATE.md: Prepended checkpoint documenting resolution and test verification.

Commands Run

• git worktree add -b agy/tyrell-feat-20260905-12-approvals-http ~/dev/_worktrees/tyrell-feat-20260905-12-approvals-http main
• swift test --test-product tyrell-appTests
• swift test --filter ApprovalClientTests
• swift test --filter ApprovalQueueTests
• swift test --filter ApprovalQueueAdversarialTests
• git commit -m 'feat(approvals): repoint ApprovalsDestination to localhost HTTP and eliminate cross-process singleton (FEAT-20260905-12)'
• git merge --ff-only agy/tyrell-feat-20260905-12-approvals-http
• git push fleet main && git push backup main
• ~/bin/ticket resolve FEAT-20260905-12 ...
• ~/.agent-coordination/agent_msg.zsh broadcast ... && ~/.agent-coordination/agent_msg.zsh sync

Verification Evidence

• Swift Testing test results:
  • TyrellDaemonApprovalClient Tests: 4 passed (0 failures).
  • ApprovalsDestination & ApprovalClient Architecture Invariants & Isolation Tests: 5 passed (0 failures).
  • Supervisor Approval Queue & Permission Policy Engine Tests: 14 passed (0 failures).
  • Adversarial Approval Queue & Recovery Tests: 3 passed (0 failures).
  • tyrell-appTests: 31 passed in 6 suites (0 failures).
• Zero ApprovalQueueActor references in app/bar verified via AST/code sweep invariant test.
• Remotes fleet (git.ecs0.net:git/apps/Tyrell.git) and backup (github.com/richhdoty/rdmsm4x-dev-apps-tyrell.git) synchronized to tip commit 1eab3ea.

Backup Locations & Undo

• Git commits ae18eab and 1eab3ea on main. To revert: git revert 1eab3ea ae18eab.
• Pre-change state preserved at base b192050.

Outstanding Owner Actions

• None. Shipped code is integrated and verified against the canonical dev tree.