rdmsm4x-changelog-20260828-1929-hyperfile-p1-peer-validation-test-quality-followup
rdmsm4x-changelog-20260828-1929-hyperfile-p1-peer-validation-test-quality-followup
Bounded test-quality follow-up: committed PID propagation coverage for the HyperFile privileged-helper peer validator, so both accepting and rejecting paths prove the original XPC client PID and the shared code-signing requirement are forwarded exactly once.
Scope
- Host:
rdmsm4x - Canonical checkout, read-only verification only:
/Users/richh/dev/apps/hyperFile,mainat9a6490008de329427f6a335840a7e0d44ae59b96, clean, with no newer overlapping changes. - Isolated worktree:
/Users/richh/dev/_worktrees/hyperfile-p1-xpc-peer-validation-20260828 - Branch:
codex/hyperfile-p1-xpc-peer-validation-20260828 - Parent implementation commit:
0964612a8fc8647b87e573dd8d1dd6abce84b11d - Follow-up commit:
8ee1e035883c11e79e3d940d0c4cda01056004be(Strengthen helper peer validation tests)
Changed file
/Users/richh/dev/_worktrees/hyperfile-p1-xpc-peer-validation-20260828/Tests/HelperPeerValidationTests.swift- The fake signature checker records each
processIdentifier. - A success-path test uses PID
73731; the failure-path test uses distinct PID42424. - Each asserts the shared
HelperPeerValidator.expectedClientCodeRequirementand one checker call.
- The fake signature checker records each
No production helper code, project generator spec, generated Xcode project, entitlement, signing, helper registration, helper installation, launch, deployment, iOS, or MCP configuration was changed.
Test-first evidence
- Before the fake recorded PIDs, the focused unsigned test command
executed 2 tests and failed both exact PID assertions: observed
[]rather than[73731]and[42424]. - After the test-double-only repair, the following passed:
xcodebuild -project HyperFile.xcodeproj -scheme HyperFileHelperPeerValidationTests -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO test
# 2 tests, 0 failures; TEST SUCCEEDED
xcodebuild -project HyperFile.xcodeproj -scheme HyperFile-macOS -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO build
# BUILD SUCCEEDED
xcodebuild -project HyperFile.xcodeproj -scheme com.eastcoastscience.HyperFile.Helper -destination 'platform=macOS' CODE_SIGNING_ALLOWED=NO build
# BUILD SUCCEEDED
git diff --check
# passed
xcodegen generate --use-cache
# HyperFile has not changed since cache was writtenThe SHA-256 digest of the isolated HyperFile.xcodeproj
file tree was unchanged before and after XcodeGen:
df06baf3c5149d75d76dea8cfeccec397c6815c6a1d0a9dadb29c7d211c3067c.
Rollback and outstanding owner action
- This change remains isolated and unmerged. To remove only the
follow-up after integration, use
git revert 8ee1e035883c11e79e3d940d0c4cda01056004bein the integration branch; before integration, remove the linked worktree/branch only after preserving the two commits as required by fleet policy. - No push, merge, signing, helper registration/installation, launch, or deployment occurred. An authorized integrator must independently review and choose whether to merge the branch.