Build 18 re-review — 2026-09-11 16:30 EDT
Owner codex@rdmsm4x/01a08a70, TASK-20260911-01. Candidate 0b0065627c58f8107fc827bcd40aa4c34aa4ec56 is not accepted. The later remote candidate is e9c990d5f00524a1df52e814675561599f8a921c; the full SHA in the delegation differed, so the verified remote object is the provenance used here.
Findings
- Confirmed: git show-ref --head is not equivalent to git bundle --all/list-heads on linked-worktree stores. Apple Git 2.54.0 (Apple Git-157) bundle headers include worktrees/linked/HEAD omitted by show-ref. Exact equality in bundleRefTips/currentRefTips rejects valid bundles. A detached linked HEAD can contain history not reachable through a branch, so do not simply filter these refs away.
- Resolved in e9c990d: ref-tip lookup failure is explicit incomplete-pass evidence; ClientLoop suppresses snapshot pruning on such a pass. Its unavailableRefTipsMakeThePassIncompleteInsteadOfAuthorizingPrune test passes canonically.
- Test infrastructure: existing help capture blocks in fflush with no pipe reader. Reproduced with normal output, script PTY, and NSUnbufferedIO=YES; each process sampled at the same function. Only our owned test processes were stopped. Fix89f5b1e uses a temporary file, flushes before redirection, preserves all help assertions, restores stdout, and cleans only its fixture. Full XCTest358 then passes. No production source changed by reviewer.
Evidence
At 0b00656 with the test-helper correction only, full selected TyrellCore suite completes: XCTest 358, one skipped, zero failures; Swift Testing 470 in34 suites, four failed tests: repoBundlePassReusesExactPathHashUntilFilesystemIdentityChanges, independentClonesWithSameHeadMustPreservePrivateRefs, sameHeadRefChangeAtomicallyInvalidatesHistoricalBundlePath, testRepoBundlerSpoolOffMainThread. Overall rc1. All fail at bundle creation.
At e9c990d, focused repo bundle/unavailable filter runs five repo tests: two pass, three fail at bundle creation. This is not a full suite result for e9c990d.
Three scripts at 0b00656 passed: agent_permission_cache_contract_test.zsh, tyrelld_stable_install_contract_test.zsh, version_single_source_contract_test.zsh.
Reproduce from review worktree /Users/richh/dev/_handoff/tyrell-build18-release-20260911/apps/Tyrell:
swift test --filter TyrellCoreTests
swift test --filter 'independentClonesWithSameHeadMustPreservePrivateRefs|sameHeadRefChangeAtomicallyInvalidatesHistoricalBundlePath|repoBundlePass|unavailable'
Full logs and three deadlock samples: /Users/richh/dev/_handoff/tyrell-build18-release-20260911/. Standalone synthetic Git fixture retained in ref-grammar-fixture/ there; no user repository was modified to reproduce the failure.
State
Source owner notified through fleet bus; ISSUE-20260911-01 updated. Await complete linked-worktree tip enumeration fix. No candidate signed, notarized, installed, or accepted on canary. Existing Build15 containment untouched; hub stable hash rechecked dbc440bd54b85a54dd6c4150b23b3e508bff7d8d8080687d81b9ba7ac2cbbcf0. Canonical main untouched. Review branch codex/tyrell-build18-rereview2-20260911 contains test-helper fix89f5b1e; no shared-library edits. Apple Notes pending because this lane reports Background, not Aqua; Markdown archive retained.
Undo: test-only changes are isolated in commit89f5b1e; revert that commit if needed. No production changes require rollback. Preserve logs and this report before removing any named review worktree.