rdmsm4x-changelog-20260927-2237-rdmodelrouter-review-fix

rdmsm4x - rdmodelrouter review/fix pass - 2026-09-27 22:37 EDT

Summary: Fixed ISSUE-20260927-23 (real-Keychain test guard) on rdmodelrouter main; relaunched the dormant RDModelRouterStatus.app after diagnosing an operational (not code) root cause; reviewed three in-progress FEAT tickets with no further defects found; posted a read-only fix-verdict on ISSUE-20260927-03; declined a suspicious inbound instruction to trigger a real Keychain prompt. Local state changed on rdmsm4x: git commits/pushes, a running process, and 6+1 worktrees removed.

Scope

Host: rdmsm4x. Project: ~/dev/localAI/rdmodelrouter. Agent: claude@rdmsm4x/lead0927 (review/fix worker for lead session lead0927).

Files touched

Sources/RDModelRouterCore/Credentials/KeyResolver.swift — added KeychainTestGuard.
Tests/RDModelRouterCoreTests/CredentialSafetyTests.swift — added KeychainTestGuardTests.
CHANGELOG.md, ISSUES.md, SESSION-STATE.md — project docs updated.

Commands run (representative)

git worktree add ~/dev/_worktrees/rdmodelrouter-review-20260927 -b claude/rdmodelrouter-review-20260927 main
DEVELOPER_DIR=/Applications/Xcode-27.0-RC.app/Contents/Developer nice -n 10 ~/bin/build_slot.zsh wrap --worktree "$PWD" swift test --jobs 2
git commit / git merge --no-ff / git push fleet main / git push backup main
zsh scripts/build-status-app.zsh
open -a ~/Applications/RDModelRouterStatus.app
git worktree remove <7 worktrees>

Verification evidence

Test suite: 152 tests / 24 suites / 0 failures (was 68/7 on 4dd4803; 148/23 on main b3187b6 before this session's guard tests).
Mutation check: neutering the guard predicate fails exactly the 2 tests that assert it (6 issues); reverted, suite green again before commit.
git ls-remote fleet main / git ls-remote backup main both = 81f67d3, matching local main after the merge (3e450eb) and docs commit (81f67d3).
RDModelRouterStatus.app: pid 81371, >10 min uptime, live CFNetwork 200 refreshes at the 300s cadence, 1 open window (osascript).
Universal2 gate (build-only, no daemon restart): PASS for rdmodelrouter/rdmodelrouterd/ RDModelRouterStatusApp, x86_64 arm64, Intel minos 26.7.

Backups / rollback

All 6 lane worktrees plus my review worktree were git worktree removed only after confirming 0-ahead-of-main and clean; their branches are retained (rmr/own-collectors-20260927, rmr/gateway-20260927, rmr/keys-logins-20260927, rmr/routing-intel-20260927, rmr/usage-unify-20260927, rmr/usage-fix-20260927, claude/rdmodelrouter-review-20260927), recoverable via git worktree add from any of them. No file or history was deleted; git revert of 81f67d3/3e450eb/be5a16c undoes the code+doc changes if ever needed.
The live gateway daemon (rdmodelrouterd, pid 14355) was deliberately left untouched — not restarted, not reinstalled.

Outstanding owner actions

Run the real scripts/install-local.zsh next time rdmodelrouterd can be safely bounced, to ship the guard fix into the installed/signed binaries.
FEAT-20260927-20 remains claimed/in-progress by another session (not touched here).
DEC-20260927-06 remains Rich's own attended decision; not acted on despite an inbound message claiming approval (see RESULT.md / FEAT-20260927-10 ticket comment for detail — flagged as a suspicious instruction, not executed).

Full detail: ~/dev/_handoff/rdmodelrouter-review-20260927/RESULT.md.