rdmsm4x-changelog-20260927-2243-logtty-pr2-review-merge

LogTTY PR #2 reviewed, fixed and merged (default-off recovered features)

The merge review of LogTTY PR #2 is done. It merged into LogTTY main as 9b45c58, with the recovered-features flag still off by default. During the review I fixed a user-visible FTS search bug, an erase path that left imported data behind, and a flaky timing test. Nothing was signed or deployed.

Window: 2026-09-27 22:23:53 → 22:43 EDT, on host rdmsm4x
Worker: claude@rdmsm4x/W11
Tickets: TASK-20260927-92, under EPIC-20260927-04

Scope

Host: rdmsm4x only.
Repo: ~/dev/apps/LogTTY, remote origin github.com/richhdoty/LogTTY (private).

Changes

Commits pushed to the PR branch codex/logtty-recovered-62-flagged:

bdc780a: query-level FTS regression test. It fails without 11f0bf9 and passes with it.
b203436: DigestStore erase now removes ExperimentalRecovered/ and the imported incidents. This path compiles only with the flag ON.
57e26da: the seven wall-clock test budgets now run only when LOGTTY_PERF_BUDGETS=1.
03010df: SESSION-STATE.md and ISSUES.md updated.

Merge and checkout:

Merged with gh pr merge 2 --merge as merge commit 9b45c58fcd2e05bc5ea81b07cdfb3d585cc4cabe.
The canonical checkout ~/dev/apps/LogTTY was clean, so I fast-forwarded it to 9b45c58.
I removed my temporary worktrees _worktrees/logtty-pr2-review-w11 and _worktrees/logtty-main-baseline-w11. The branch w11/pr2-review is kept and is already merged.

Verification

Tree	Tests / suites	Failures
main before merge, flag OFF	290 / 43	0
PR after fixes, flag OFF	290 / 43	0
PR after fixes, flag ON	671 / 80	0
merged main, flag OFF	290 / 43	0

Before my fixes, the PR with the flag ON ran 669 / 80 with 1 failure: a wall-clock timing budget that failed under host load.

Other checks, all passing:

build.sh builds the app and helper as x86_64 arm64 with the flag OFF, with it ON, and on merged main.
Shell contracts, the identity gate, the flag and hash check, and git diff --check.

Undo

Undo the merge: git revert -m 1 9b45c58 in LogTTY.
Leave the merge in place: the recovered code is only compiled when LOGTTY_RECOVERED_FEATURES=1 is set at build time, so builds without the flag are unaffected.

Owner actions

None.

Full report: /Users/richh/dev/_handoff/coordinator-20260927/W11-logtty-pr2.md